Fix namespace collision for string and CollectionUtils method IsNullOrEmpty
#2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekkumams
requested review from
Aniruddh25,
seantleonard,
aaronburtle,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
aaronburtle
approved these changes
Nov 21, 2024
|
Actually, after searching the codebase there was only 1 more instance where string was being null checked wrong, so just added it in here, hope that's OK @abhishekkumams |
|
/azp run |
|
/azp run |
Aniruddh25
reviewed
Nov 22, 2024
Aniruddh25
reviewed
Nov 22, 2024
Aniruddh25
previously requested changes
Nov 22, 2024
It's still being used for the reason pointed out by Sean: #2471 (comment) |
|
/azp run |
abhishekkumams
added a commit
that referenced
this pull request
Nov 28, 2024
…OrEmpty` (#2471) ## Why make this change? - Closes #2469 - There is a namespace collision for the `IsNullOrEmpty` method in the `MsSqlQueryBuilder` class between String and CollectionUtils class. ## What is this change? - `MsSqlQueryBuilder` class had a check in the `Build` method where it was using `IsNullOrEmpty` for Strings but it was refrencing CollectionUtils Class instead - Removed `Collection.Utilities` class from Cli and renamed it in the Core project to `EnumerableUtilities` to avoid any future namespace collision. - Also updated all the references of `IsNullOrEmpty` ## How was this tested? - [x] manual tests - [x] current existing tests Notes: Work Around shared here: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#1722 --------- Co-authored-by: Aaron Burtle <[email protected]> Co-authored-by: aaronburtle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
IsNullOrEmptymethod in theMsSqlQueryBuilderclass between String and CollectionUtils class.What is this change?
MsSqlQueryBuilderclass had a check in theBuildmethod where it was usingIsNullOrEmptyfor Strings but it was refrencing CollectionUtils Class insteadCollection.Utilitiesclass from Cli and renamed it in the Core project toEnumerableUtilitiesto avoid any future namespace collision.IsNullOrEmptyHow was this tested?
Notes:
Work Around shared here: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#1722