Do not allow Mode to Hot-Reload #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Aniruddh25,
seantleonard,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
|
/azp run |
|
Thanks @aaronburtle for quick fix. |
abhishekkumams
force-pushed
the
dev/aaronburtle/ModeHotReload
branch
from
0d1a9e0 to
450eb32
Compare
|
/azp run |
abhishekkumams
approved these changes
Nov 26, 2024
|
/azp run |
RubenCerna2079
approved these changes
Nov 26, 2024
Aniruddh25
reviewed
Nov 27, 2024
Aniruddh25
reviewed
Nov 27, 2024
|
/azp run |
|
/azp run |
abhishekkumams
added a commit
that referenced
this pull request
Nov 28, 2024
## Why make this change? Closes #2457 ## What is this change? We add in an optional parameter to the `TryLoadConfig` function so that when we Hot-Reload, we can pass along the `Mode`. When that parameter is included (and therefore non null), we overwrite the Mode of the `RuntimeConfig` to match the value of the previous `RuntimeConfig`. This means that this Mode needs to have a public setter however, which we now utilize to overwrite. ## How was this tested? Modified our Unit test to provide coverage. ## Sample Request(s) Any hot-reload that tries to change the mode will demonstrate the functionality. So start the engine in dev mode, so that the filewatcher will pick up any changes as we dont currently support hot-reload in production, then change the Host Mode from development to production, and note that the RuntimeConfig in-memory object is still in dev mode. --------- Co-authored-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2457
What is this change?
We add in an optional parameter to the
TryLoadConfigfunction so that when we Hot-Reload, we can pass along theMode. When that parameter is included (and therefore non null), we overwrite the Mode of theRuntimeConfigto match the value of the previousRuntimeConfig. This means that this Mode needs to have a public setter however, which we now utilize to overwrite.How was this tested?
Modified our Unit test to provide coverage.
Sample Request(s)
Any hot-reload that tries to change the mode will demonstrate the functionality. So start the engine in dev mode, so that the filewatcher will pick up any changes as we dont currently support hot-reload in production, then change the Host Mode from development to production, and note that the RuntimeConfig in-memory object is still in dev mode.