Make dotnet watch run restart on json and gql changes #50
Conversation
JelteF
requested review from
Aniruddh25,
jarupatj,
mbhaskar,
moderakh and
seantleonard
as code owners
| @@ -14,6 +14,11 @@ | |||
| </Content> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <!-- extends watching group to include .json and .gql files --> | |||
| <Watch Include="**\*.json;**\*.gql" Exclude="obj\**\*;bin\**\*" /> | |||
There was a problem hiding this comment.
At some point, I'd imagine we scope this to a given configuration folder instead of a catch all on file type? I'm thinking about some maybe non-restart critical updates to JSON files such as for VSCode/ IDE configuration.
There was a problem hiding this comment.
Yeah that would make sense. Let's do that once people start running into issues because of this.
|
Looks good. |
There was a problem hiding this comment.
we shouldn't restart the whole DotNet application.
I think we shouldn't do this from Cosmos.GraphQL.Service.csproj
Doing it from the proj file may actually cause a bit of disruption when we develop and locally edit something in the project folder.
IMO, we should park this work till have a better understanding of the requirements of Config update and directory watcher.
| @@ -14,6 +14,11 @@ | |||
| </Content> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <!-- extends watching group to include .json and .gql files --> | |||
There was a problem hiding this comment.
we shouldn't restart the whole DotNet application.
I think we shouldn't do this from Cosmos.GraphQL.Service.csproj
Doing it from the proj file may actually cause a bit of disruption when we develop and locally edit something in the project folder.
IMO, we should park this work till have a better understanding of the requirements of Config update and directory watcher.
There was a problem hiding this comment.
It only does the restart when you run the application with dotnet watch run (note the watch part). This command is meant to restart the application whenever any file changes, so you can easily test out your changes. Withou this changes it only restarts the application when you change a .cs file. Now it does it as well if you change the configs. If you don't like this workflow, you can still use plain dotnet run.
There was a problem hiding this comment.
To be clear, this is separate from any automatic config reloading that we would implement in the application that users would use. That's something we might implement in the future. This is simply correctly configuring dev tooling that we (the devs on this project) can use.
There was a problem hiding this comment.
I tried this out and found this useful to enhance my development loop when I'm using dotnet watch. This doesnt affect anything if I'm not doing a watch, so I think this change can go in.
There was a problem hiding this comment.
@moderakh @jarupatj are you okay with merging this? The IOptionsMonitor definitely looks like more work to implement, and the current approach enhances the dev loop when using dotnet watch. So this PR seems like a net improvement to me. Once we implement real config reloading in the app itself, we will probably remove these lines from csproj. But until then this seems like a good workaround, so I think this should be merged. Let's try not to fall into the trap where perfect is the enemy of good.
There was a problem hiding this comment.
It is ok with me. Can we have a work item to track this work?
There was a problem hiding this comment.
Added a workitem here: #67
|
You should look at using IOptionsMonitor |
When running with `dotnet watch run` the binary gets rebuilt and restarted whenever a `.cs` file changes. For this project a lot of behaviour is defined in the config files though. This makes sure the `watch run` restarts the program whenever a json or gql file is modified in the project.
JelteF
force-pushed
the
watch-include-configs
branch
from
4a9a57a to
783185e
Compare
When running with
dotnet watch runthe binary gets rebuilt andrestarted whenever a
.csfile changes. For this project a lot ofbehaviour is defined in the config files though. This makes sure the
watch runrestarts the program whenever a json or gql file is modifiedin the project.