Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix casing in import statement #21

Merged
merged 1 commit into from
Jun 29, 2017
Merged

fix casing in import statement #21

merged 1 commit into from
Jun 29, 2017

Conversation

XenoPhex
Copy link
Contributor

@XenoPhex XenoPhex commented Jun 9, 2017

This library is causing us to have two folders in our vendor called Sirupsen and sirupsen. According to the sirupsen/logrus's README:

Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

Fixing these import statements would save us some duplication.

@msftclas
Copy link

msftclas commented Jun 9, 2017

@XenoPhex,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@lussn
Copy link

lussn commented Jun 13, 2017

Thanks @XenoPhex , same issue here.

@XenoPhex
Copy link
Contributor Author

Adding a link back to the original issue: moby/moby#33641

@msftclas
Copy link

@XenoPhex, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@XenoPhex
Copy link
Contributor Author

Legal finally got back to me, got all the things signed!

@jstarks
Copy link
Collaborator

jstarks commented Jun 29, 2017

Great, thanks!

I'll go ahead and merge this one since this repo doesn't see many modifications. Then moby can revendor whenever they're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants