Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureAPI interface type #600

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

jhendrixMSFT
Copy link
Member

To be used for mocking Future response types.

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  • I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
  • If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

To be used for mocking Future response types.
@jhendrixMSFT
Copy link
Member Author

Part of the fix for Azure/azure-sdk-for-go#14010

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I dont know if these are all of the methods that the Future would need, but it seems complete.

@jhendrixMSFT
Copy link
Member Author

It's all the exported methods currently defined on the azure.Future type.

@catalinaperalta
Copy link
Member

It's all the exported methods currently defined on the azure.Future type.

The azure.Future type that's outputted in the generated code right?

@jhendrixMSFT jhendrixMSFT merged commit cbd6c47 into Azure:master Dec 17, 2020
@jhendrixMSFT jhendrixMSFT deleted the autorest_futureapi branch December 17, 2020 21:35
@jhendrixMSFT
Copy link
Member Author

No, the Future type defined in the autorest/azure package in this repo. This is all of the widget-agnostic methods, the others are part of the generated code (similar to track 2).

@catalinaperalta
Copy link
Member

Ah ok, got it. Thanks for the info! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants