Add a task to build iotedged with feature=runtime-kubernetes during checkin. #1606
Conversation
darobs
changed the title
|
In that case, please change the regular |
listed are all the projects which do not require features set.
| ############################################################################### | ||
| # These are the packages this script will build. | ||
| ############################################################################### | ||
| packages=(iotedge iotedged iotedge-diagnostics iotedge-proxy) |
There was a problem hiding this comment.
We need iotedge-proxy for non-Kubernetes?
There was a problem hiding this comment.
iotedge-proxy is not build with the feature "runtime-kubernetes" - it's built with the default features.
I've gone back and forth on this. It was easier to add to the list of packages, and where it is placed does not impact build time, but it is not required for non-k8s work. If other people have strong opinions on placement, I'll gladly move it.
There was a problem hiding this comment.
If it was meant for non-Kubernetes I would've liked to be on the code review for when it was merged. Just from a quick glance I see it's not doing error-handling correctly.
Anyway, what features it's built with isn't the way we should differentiate. Was it planned to ship in iotedge.deb ? Then it's part of the regular build. If it wasn't, then it's not.
I'm fine with leaving it where it is, but in the future if you're planning on doing non-Kubernetes work, please involve the non-Kubernetes team in the code reviews.
There was a problem hiding this comment.
Added a bug to our backlog to get our error handling in sync with the rest of the project.
In order to make sure changes in one module runtime (Docker) don't break the other module runtime (Kubernetes), I added a step in the linux amd64 Checkin build to build iotedged with the runtime-kubernetes feature turned on.