-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send connection device Id information on twin change notifications #4762 #4888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7026ec6.
…zure#4762) Issue: EdgeHub supports routing twin change notifications, which basically includes routing RP updates to other modules. The message that gets routed should have information about the device that sent the RP update. But because of a recent change in EH, this information got dropped. Azure#4689 Fix: Fix is to route the information about the device/module that sent the RP update to the receiving module.
ancaantochi
approved these changes
Apr 22, 2021
varunpuranik
added a commit
to varunpuranik/iotedge
that referenced
this pull request
Jun 16, 2021
…ure#4762 (Azure#4888) Cherry-pick: Azure@fa60e52 Issue: EdgeHub supports routing twin change notifications, which basically includes routing RP updates to other modules. The message that gets routed should have information about the device that sent the RP update. But because of a recent change in EH, this information got dropped. Fix: Fix is to route the information about the device/module that sent the RP update to the receiving module.
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
#5145) …762 (#4888) Cherry-pick: fa60e52 Issue: EdgeHub supports routing twin change notifications, which basically includes routing RP updates to other modules. The message that gets routed should have information about the device that sent the RP update. But because of a recent change in EH, this information got dropped. Fix: Fix is to route the information about the device/module that sent the RP update to the receiving module.
ggjjj
pushed a commit
to ggjjj/iotedge
that referenced
this pull request
Jul 22, 2021
…ure#4762 (Azure#4888) Cherry-pick: Azure@fa60e52 Issue: EdgeHub supports routing twin change notifications, which basically includes routing RP updates to other modules. The message that gets routed should have information about the device that sent the RP update. But because of a recent change in EH, this information got dropped. Azure#4689 Fix: Fix is to route the information about the device/module that sent the RP update to the receiving module.
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
…ure#4762 (Azure#4888) Cherry-pick: Azure@fa60e52 Issue: EdgeHub supports routing twin change notifications, which basically includes routing RP updates to other modules. The message that gets routed should have information about the device that sent the RP update. But because of a recent change in EH, this information got dropped. Azure#4689 Fix: Fix is to route the information about the device/module that sent the RP update to the receiving module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: fa60e52
Issue: EdgeHub supports routing twin change notifications, which basically includes routing RP updates to other modules. The message that gets routed should have information about the device that sent the RP update.
But because of a recent change in EH, this information got dropped.
#4689
Fix: Fix is to route the information about the device/module that sent the RP update to the receiving module.