Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module list API definition to workload OpenAPI spec #523

Merged
merged 3 commits into from
Nov 12, 2018

Conversation

avranju
Copy link
Contributor

@avranju avranju commented Nov 7, 2018

No description provided.

@mrohera
Copy link
Member

mrohera commented Nov 7, 2018

Curious, how did this work without this change? Also don't you have to code gen this to update docs, interfaces etc.?

@avranju
Copy link
Contributor Author

avranju commented Nov 7, 2018

While we do have a client in iotedged that uses some of the APIs specified in these YAML files, this particular API is not currently used from Edge. As for docs -- do we actually have this API documented somewhere?

Copy link
Member

@mrohera mrohera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next person to use the Rust code gen util for the iotedged might find that they have to remove any generated code for this new API. I am not sure either bite the bullet now or in a subsequent PR but we might have to stub this out in iotedged or at least add to the dev guide or something.

@avranju avranju merged commit 5547161 into Azure:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants