Skip to content

Commit

Permalink
remove all-zero default value in helm chart azureconfig
Browse files Browse the repository at this point in the history
  • Loading branch information
jwtty committed Aug 5, 2024
1 parent 0ab48a9 commit a8a5e62
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 14 deletions.
2 changes: 1 addition & 1 deletion helm/kube-egress-gateway/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ maintainers:
name: Li Ma
sources:
- https://github.com/Azure/kube-egress-gateway
version: 0.1.2
version: 0.1.3
12 changes: 4 additions & 8 deletions helm/kube-egress-gateway/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,16 @@ This Helm chart enables installation and maintenance of Azure kube-egress-gatewa

## Installation

Clone this repository, kube-egress-gateway chart is maintained in `helm/kube-egress-gateway` directory:
```
git clone https://github.com/Azure/kube-egress-gateway.git
```

To install `kube-egress-gateway`, you may run below `helm` command:

```bash
$ helm install \
kube-egress-gateway ./helm/kube-egress-gateway \
--repo https://raw.githubusercontent.com/Azure/kube-egress-gateway/main/helm/repo \
kube-egress-gateway --generate-name \
--namespace kube-egress-gateway-system \
--create-namespace \
--set common.imageRepository=mcr.microsoft.com/aks \
--set common.imageTag=v0.0.11 \
--set common.imageTag=v0.0.14 \
-f azure_config.yaml
```

Expand Down Expand Up @@ -60,7 +56,7 @@ config:
tenantId: "00000000-0000-0000-0000-000000000000"
subscriptionId: "00000000-0000-0000-0000-000000000000"
useManagedIdentityExtension: false
userAssignedIdentityID: "00000000-0000-0000-0000-000000000000"
userAssignedIdentityID: "00000000-0000-0000-0000-000000000000" # no need if useManagedIdentityExtension == false
aadClientId: "00000000-0000-0000-0000-000000000000"
aadClientSecret: "<your secret>"
userAgent: "kube-egress-gateway-controller"
Expand Down
8 changes: 4 additions & 4 deletions helm/kube-egress-gateway/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ gatewayCNIIpam:
config:
azureCloudConfig:
cloud: "AzurePublicCloud"
tenantId: "00000000-0000-0000-0000-000000000000"
subscriptionId: "00000000-0000-0000-0000-000000000000"
tenantId: ""
subscriptionId: ""
useManagedIdentityExtension: false
userAssignedIdentityID: "00000000-0000-0000-0000-000000000000"
aadClientId: "00000000-0000-0000-0000-000000000000"
userAssignedIdentityID: ""
aadClientId: ""
aadClientSecret: ""
userAgent: "kube-egress-gateway-controller"
resourceGroup: ""
Expand Down
20 changes: 19 additions & 1 deletion helm/repo/index.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,24 @@
apiVersion: v1
entries:
kube-egress-gateway:
- apiVersion: v2
created: "2024-08-05T06:45:54.269241169Z"
description: A Helm chart for installing Azure kube-egress-gateway components
digest: dec258bb39f9fc167a674707eb2624a96402eee95c754c0018bfd93fe52979a6
maintainers:
- email: [email protected]
name: Wantong Jiang
- email: [email protected]
name: Shangxiang Fan
- email: [email protected]
name: Li Ma
name: kube-egress-gateway
sources:
- https://github.com/Azure/kube-egress-gateway
type: application
urls:
- kube-egress-gateway-0.1.3.tgz
version: 0.1.3
- apiVersion: v2
created: "2024-03-09T16:46:15.139200257Z"
description: A Helm chart for installing Azure kube-egress-gateway components
Expand Down Expand Up @@ -55,4 +73,4 @@ entries:
urls:
- kube-egress-gateway-0.1.0.tgz
version: 0.1.0
generated: "2024-03-09T16:46:15.138582324Z"
generated: "2024-08-05T06:45:54.26865312Z"
Binary file added helm/repo/kube-egress-gateway-0.1.3.tgz
Binary file not shown.

0 comments on commit a8a5e62

Please sign in to comment.