Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue caused by updating azure.json #37

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Fix issue caused by updating azure.json #37

merged 1 commit into from
Nov 27, 2018

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Nov 22, 2018

Fixes Azure/aks-engine#49

  • When an encrypt request or a decrypt request occurs during a config (azure.json) update, config can be nil as the content is inflight. Handle nil config during a config update.
  • Update the local providerKeyVersion property once we get a keyversion from keyvault so that we only update the config when providerKeyVersion is empty

@feiskyer
Copy link
Member

👍

@ritazh ritazh merged commit f361265 into master Nov 27, 2018
@ritazh ritazh deleted the fix-writefile branch December 20, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants