Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Azure/notation-azure-kv
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.0-rc.1
Choose a base ref
...
head repository: Azure/notation-azure-kv
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.0-rc.2
Choose a head ref
  • 7 commits
  • 24 files changed
  • 1 contributor

Commits on May 8, 2023

  1. doc: update artifact version in readme (#106)

    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 8, 2023
    Copy the full SHA
    fb3d95d View commit details
  2. doc: update version for README (#107)

    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 8, 2023
    Copy the full SHA
    07677f4 View commit details
  3. doc: add macOS codesign (#108)

    Add macOS codesign
    
    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 8, 2023
    Copy the full SHA
    f2a6eac View commit details

Commits on May 9, 2023

  1. feat: optimize JSON serializer (#111)

    - optimize the JSON serializer with generated code
    - remove part of warning for trim unused code
    - optimize binary load time
    
    Resolve part of #109 
    
    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 9, 2023
    Copy the full SHA
    307d0bb View commit details

Commits on May 12, 2023

  1. ci: update release ci to use macOS (#110)

    The binaries for macOS cannot be executed without macOS codesign, so
    optimize the pipeline to include codesign.
    
    - Updated CI to build binaries on Linux and codesign on macOS
    - Use Github Artifact store temporary files between jobs. The retention
    time is 1 day.
    
    Example release:
    https://github.com/JeyJeyGao/notation-azure-kv/releases/tag/v1.0.46
    Example action:
    https://github.com/JeyJeyGao/notation-azure-kv/actions/runs/4948193196
    
    Test:
    - Linux x64 bianry
    - Windows x64 binary
    - macOS arm64 bianry
    - macOS x64 bianry
    
    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 12, 2023
    Copy the full SHA
    e919142 View commit details

Commits on May 16, 2023

  1. fix: check command before read input (#112)

    Fix:
    - before the fixing, the plugin needs to read the input before check the
    command name
    - after the fixing, the plugin check the command name before reading the
    input
    
    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 16, 2023
    Copy the full SHA
    d49ee99 View commit details

Commits on May 24, 2023

  1. fix: optimize the error message for unmatchable certificate bundle (#113

    )
    
    Fix: 
    - optimize the error message for unmatchable certificate bundle (correct
    DNs but incorrect public key)
    - optimize error message for partial chain
    
    
    Test:
    Previous error message:
    ```json
    {
      "errorCode": "ERROR",
      "errorMessage": "Error occurred during a cryptographic operation."
    }
    ```
    
    Current error message:
    ```json
    {
      "errorCode": "VALIDATION_ERROR",
      "errorMessage": "Failed to build the X509 chain. Error occurred during a cryptographic operation. The certificate bundle is unreadable. Please ensure the certificate bundle matches the specific certifcate."
    }
    ```
    Resolves #114 
    Signed-off-by: Junjie Gao <[email protected]>
    
    ---------
    
    Signed-off-by: Junjie Gao <[email protected]>
    JeyJeyGao authored May 24, 2023
    Copy the full SHA
    b284687 View commit details
Loading