Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check command before read input #112

Merged
merged 3 commits into from
May 16, 2023

Conversation

JeyJeyGao
Copy link
Collaborator

Fix:

  • before the fixing, the plugin needs to read the input before check the command name
  • after the fixing, the plugin check the command name before reading the input

Signed-off-by: Junjie Gao [email protected]

@JeyJeyGao JeyJeyGao requested a review from shizhMSFT May 15, 2023 08:00
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #112 (e8aaefb) into main (e919142) will increase coverage by 8.80%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   84.94%   93.75%   +8.80%     
==========================================
  Files          15       15              
  Lines         465      464       -1     
==========================================
+ Hits          395      435      +40     
+ Misses         70       29      -41     
Impacted Files Coverage Δ
Notation.Plugin.AzureKeyVault/Program.cs 76.92% <100.00%> (+76.92%) ⬆️

JeyJeyGao added 2 commits May 15, 2023 16:27
Signed-off-by: Junjie Gao <[email protected]>
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit d49ee99 into Azure:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants