Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error message improvement #178

Closed
JeyJeyGao opened this issue May 14, 2024 · 2 comments
Closed

error message improvement #178

JeyJeyGao opened this issue May 14, 2024 · 2 comments
Assignees
@JeyJeyGao

Comments

@JeyJeyGao
Copy link
Collaborator

JeyJeyGao commented May 14, 2024 •
edited
Loading

VALIDATION_ERROR: Invalid input. The valid input format is '{"contractVersion":"1.0","keyId":"https://.vault.azure.net/<keys|certificate>//"}'
Error: Error: The process '/home/runner/work/_temp/b0e9f994-081d-44f1-88df-f056d94313f4/notation' failed with exit code 1

This error message is difficult to understand. We need to improve it by making it clearer, providing a descriptive message, and offering actionable suggestions.
@JeyJeyGao JeyJeyGao self-assigned this May 14, 2024
@FeynmanZhou
Copy link
Member

FeynmanZhou commented May 24, 2024 •
edited
Loading

@JeyJeyGao Please see my suggested change in notaryproject/notation-go#404 (comment). Also linking to #180 as an ultimate solution.

@JeyJeyGao JeyJeyGao mentioned this issue May 27, 2024
Merged
JeyJeyGao added a commit that referenced this issue May 29, 2024
@JeyJeyGao
feat: add versionless key identifier support (#181)
f82c165 
Feat:
- added versionless key/certificate identifier support

Test:
- added unit test
- added E2E test

Docs:
- added tips for versionless id feature
- fixed NOTE marks

Resolves #180 #178 
Signed-off-by: Junjie Gao <[email protected]>

---------

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
Copy link
Collaborator Author

Resolved in #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeyJeyGao JeyJeyGao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FeynmanZhou @JeyJeyGao