-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add self_signed pluginConfig #119
Conversation
Signed-off-by: Junjie Gao <[email protected]>
e3ce8cd
to
390e0cb
Compare
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 93.97% 94.19% +0.22%
==========================================
Files 15 15
Lines 448 465 +17
==========================================
+ Hits 421 438 +17
Misses 27 27
|
390e0cb
to
5d13252
Compare
Signed-off-by: Junjie Gao <[email protected]>
5d13252
to
03f0f24
Compare
Signed-off-by: Junjie Gao <[email protected]>
3b2ba20
to
0abb91c
Compare
Signed-off-by: Junjie Gao <[email protected]>
94b34bb
to
eded4d1
Compare
Signed-off-by: Junjie Gao <[email protected]>
58cc283
to
e54868a
Compare
Signed-off-by: Junjie Gao <[email protected]>
fc138b8
to
10fc2d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highly recommend that we document this behavior somewhere in this Repo for user's reference, otherwise the learning experience for new users gonna be a real pain :)
Parameters logic:
self_signed is true && ca_certs=/path/to/cacerts ==> exception
self_signed is true && ca_certs is null or empty ==> get self-signed certificate with Certificates Get permission
self_signed is false or not set && ca_certs=/path/to/cacerts ==> get leaf certificate with Certificates Get permission and read the certificate bundle from file
self_signed is false or not set && ca_certs is not set or empty ==> get certificate chain with Secrets Get permission
I will create a new RR to update the documentations and include your suggestion. |
Feat:
Certificates Get
permission)Fix:
self_signed
andca_certs
are not set (Secrets Get
permission)Parameters logic:
Certificates Get
permissionCertificates Get
permission and read the certificate bundle from fileSecrets Get
permissionSigned-off-by: Junjie Gao [email protected]