Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix&test(e2e): mariner containerized e2e test #149

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Jan 24, 2024

test:

  • added containerized azure-kv plugin E2E test based on mcr.microsoft.com/cbl-mariner/base/core:2.0

fix:

  • set InvariantGlobalization mode to avoid access culture-specific data, which removes the dependency of icu-libs (not contained in mariner image)

Signed-off-by: Junjie Gao [email protected]

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d8f4af) 91.65% compared to head (0c12f25) 91.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          16       16           
  Lines         551      551           
  Branches       67       67           
=======================================
  Hits          505      505           
  Misses         33       33           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao changed the title test(e2e): containerized test test(e2e): mariner containerized e2e test Jan 24, 2024
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review January 24, 2024 13:47
@JeyJeyGao JeyJeyGao requested a review from shizhMSFT January 24, 2024 13:48
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao changed the title test(e2e): mariner containerized e2e test fix&test(e2e): mariner containerized e2e test Jan 25, 2024
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/test.yml Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao merged commit e1442cd into main Jan 26, 2024
14 checks passed
@JeyJeyGao JeyJeyGao deleted the test/containerized branch January 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants