Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update credential type logic #164

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Apr 16, 2024

Fix:

  • removed default credential type

Signed-off-by: Junjie Gao [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.51%. Comparing base (027f966) to head (69646ec).

Files Patch % Lines
...ation.Plugin.AzureKeyVault/KeyVault/Credentials.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   91.65%   91.51%   -0.14%     
==========================================
  Files          17       17              
  Lines         599      601       +2     
  Branches       74       75       +1     
==========================================
+ Hits          549      550       +1     
  Misses         37       37              
- Partials       13       14       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao marked this pull request as ready for review April 16, 2024 02:16
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT force-pushed the fix/update_credential_logic branch from 12427bf to 69646ec Compare April 16, 2024 09:47
@shizhMSFT shizhMSFT merged commit 3c99ce9 into main Apr 16, 2024
10 checks passed
@shizhMSFT shizhMSFT deleted the fix/update_credential_logic branch April 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants