-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve reliability #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 17 17
Lines 617 617
Branches 78 78
=======================================
Hits 574 574
Misses 31 31
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: as the default
ubuntu-latest
runner has upgraded toubuntu-24.04
, we need to ensure compatibility with older OS versions if we release the binary on a new runner as the dotnet building process depends on OS libraries (for example,GLIBC
).CI:
Unit test pipeline
E2E pipeline
linux-x64
binary onubuntu-24.04
and tested onubuntu-22.04
,ubuntu-24.04
andmcr.microsoft.com/cbl-mariner/base/core:2.0
container.linux-arm64
binary onubuntu-24.04-arm
and tested onubuntu-24.04-arm
,ubuntu-22.04-arm
.windows-x64
binary onwindows-2022
and tested onwindows-2022
andwindows-2025
(GA).release pipeline
ubuntu 24.04
for Linux and macOS binaries andwindows-2022
for Windows binary.ubuntu-24.04-arm
runner.Test:
Note: win-x64 build generates a warning which is discussed here: dotnet/runtime#109958. It should be fixed in the future dotnet release.