Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve reliability #232

Merged
merged 9 commits into from
Jan 22, 2025
Merged

ci: improve reliability #232

merged 9 commits into from
Jan 22, 2025

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Jan 22, 2025

Background: as the default ubuntu-latest runner has upgraded to ubuntu-24.04, we need to ensure compatibility with older OS versions if we release the binary on a new runner as the dotnet building process depends on OS libraries (for example, GLIBC).

CI:

  • Unit test pipeline

    • added unit test on Linux arm64 and windows x64.
  • E2E pipeline

    • built linux-x64 binary on ubuntu-24.04 and tested on ubuntu-22.04, ubuntu-24.04 and mcr.microsoft.com/cbl-mariner/base/core:2.0 container.
    • built linux-arm64 binary on ubuntu-24.04-arm and tested on ubuntu-24.04-arm, ubuntu-22.04-arm.
    • built windows-x64 binary on windows-2022 and tested on windows-2022 and windows-2025 (GA).
  • release pipeline

    • updated release pipeline to use ubuntu 24.04 for Linux and macOS binaries and windows-2022 for Windows binary.
    • removed ARM emulator from release pipeline and replaced with ubuntu-24.04-arm runner.

Test:

  • fixed unit test on windows to avoid line ending symbol issue
  • tested new release pipeline in forked repo

Note: win-x64 build generates a warning which is discussed here: dotnet/runtime#109958. It should be fixed in the future dotnet release.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (b57e76f) to head (cf4f5b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files          17       17           
  Lines         617      617           
  Branches       78       78           
=======================================
  Hits          574      574           
  Misses         31       31           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 79fcd26 into main Jan 22, 2025
15 checks passed
@JeyJeyGao JeyJeyGao deleted the ci/improve_reliability branch January 22, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants