doc: update README #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 69.60% 69.60%
=======================================
Files 6 6
Lines 306 306
=======================================
Hits 213 213
Misses 87 87
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
feat/update_doc
branch
from
d118e62 to
d278fc8
Compare
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Mar 10, 2023
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
changed the title
FeynmanZhou
reviewed
Mar 13, 2023
FeynmanZhou
requested changes
Mar 13, 2023
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Mar 14, 2023
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Mar 14, 2023
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Mar 15, 2023
Signed-off-by: Junjie Gao <[email protected]>
yizha1
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Thanks @JeyJeyGao . Is it better that we can create separate docs for the self-signed and certificate chain and link them from readme.md file. The reasons are:
- readme.md is too long
- Any changes on notation sign/verify or certificates, the readme.md should be updated, which seems not approprate.
zr-msft
suggested changes
Mar 17, 2023
FeynmanZhou
reviewed
Mar 20, 2023
FeynmanZhou
reviewed
Mar 20, 2023
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Mar 30, 2023
Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve part of #78
Signed-off-by: Junjie Gao [email protected]