feat: implement get-plugin-metadata & describe-key command in dotnet #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 69.60% 69.60%
=======================================
Files 6 6
Lines 306 306
=======================================
Hits 213 213
Misses 87 87
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
reviewed
Apr 18, 2023
akv-plugin/proto/key.cs
Outdated
Comment on lines
42
to
68
| RSA? rsaKey = signingCert.GetRSAPublicKey(); | ||
| ECDsa? ecdsaKey = signingCert.GetECDsaPublicKey(); | ||
|
|
||
| if (rsaKey != null) | ||
| { | ||
| int bitSize = rsaKey.KeySize; | ||
|
|
||
| if (bitSize == 2048 || bitSize == 3072 || bitSize == 4096) | ||
| { | ||
| return new KeySpec("RSA", bitSize); | ||
| } | ||
|
|
||
| throw new ValidationException($"RSA key size {bitSize} bits is not supported"); | ||
| } | ||
| else if (ecdsaKey != null) | ||
| { | ||
| int bitSize = ecdsaKey.KeySize; | ||
|
|
||
| if (bitSize == 256 || bitSize == 384 || bitSize == 521) | ||
| { | ||
| return new KeySpec("EC", bitSize); | ||
| } | ||
|
|
||
| throw new ValidationException($"ECDSA key size {bitSize} bits is not supported"); | ||
| } | ||
|
|
||
| throw new ValidationException("Unsupported public key type"); |
There was a problem hiding this comment.
Can we have other better way to determine the public key?
There was a problem hiding this comment.
We can get the key by signingCert.PublicKey.Key but PublicKey.Key is obsolete. It asks me to use the appropriate method to get the public key, such as GetRSAPublicKey.
So I optimized the code based on current logic.
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
feat/dotnet_plugin
branch
from
41bb4de to
c687536
Compare
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Apr 19, 2023
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Apr 20, 2023
Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve part of #90
Signed-off-by: Junjie Gao [email protected]