feat: add .NET verion generate-signature command #91
Conversation
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 69.60% 69.60%
=======================================
Files 6 6
Lines 306 306
=======================================
Hits 213 213
Misses 87 87
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
|
I guess my first question would be: has this new feature been tested with our notation CLI and AKV? |
Signed-off-by: Junjie Gao <[email protected]>
Yes, it was tested with Notation CLI. Updated the PR description. |
Signed-off-by: Junjie Gao <[email protected]>
| @@ -9,22 +9,62 @@ namespace Notation.Plugin.Protocol | |||
| public class GenerateSignatureRequest | |||
There was a problem hiding this comment.
Just curious if record can be applied or not.
There was a problem hiding this comment.
I think it works, but it may not help a lot because I still need to define the JsonPropertyName and manually do the the parameter validation during initialization.
There was a problem hiding this comment.
Thanks Shiwei! Updated to use record in KeyVaultClient.
|
|
||
| if (signResult.KeyId != _keyId) | ||
| { | ||
| throw new PluginException("Invalid keys or certificates identifier."); |
There was a problem hiding this comment.
It is not invalid but mismatch? When will this happen? What's the scenario for that? If the exception is thrown, should we also include the key id we want and got?
There was a problem hiding this comment.
I tested invalid key names and versions, and in both cases, SignDataAsync raised exceptions. Although I didn't find a real case that could trigger the exception, it's included to handle server errors that might return unexpected values.
Also updated the exception to include the KeyId.
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Features:
ca_certspluginConfig to build the cert chain from custom certificate bundleTested with Notation CLI:
Resolve part of #90
Signed-off-by: Junjie Gao [email protected]