Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup for L0 Testcases #6

Merged
merged 9 commits into from
Jul 1, 2020
Merged

Setup for L0 Testcases #6

merged 9 commits into from
Jul 1, 2020

Conversation

rgsubh
Copy link
Contributor

@rgsubh rgsubh commented Jun 13, 2020

No description provided.

@rgsubh rgsubh marked this pull request as draft June 13, 2020 07:05
@github-actions
Copy link

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 27.91 0 14.29 27.91
run.ts 27.91 0 14.29 27.91 14-64,69-77

@rgsubh rgsubh marked this pull request as ready for review June 13, 2020 07:48
@github-actions
Copy link

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 27.91 0 14.29 27.91
run.ts 27.91 0 14.29 27.91 14-64,69-77

@rgsubh rgsubh requested a review from thesattiraju June 15, 2020 04:15
thesattiraju
thesattiraju reviewed Jun 15, 2020
View reviewed changes
.github/workflows/test.yml Outdated
$headers = @{
"Authorization" = "token ${env:GITHUB_TOKEN}"
}
Invoke-RestMethod -Method POST -Uri $url -Headers $headers -Body "{ `"body`": `"${comment}`" }"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as Azure/k8s-set-context#8

@github-actions
Copy link

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 27.91 0 14.29 27.91
run.ts 27.91 0 14.29 27.91 14-64,69-77

thesattiraju
thesattiraju approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@thesattiraju thesattiraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on the k8s-set-context PR. They apply here as well.

Given that they're cosmetic changes; I leave it to you to consider taking those up. 😄

package.json
"@types/node": "^12.0.4",
"jest": "^26.0.1",
"@types/jest": "^25.2.2",
"ts-jest": "^25.5.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-jest isn't being used yet right?

@github-actions
Copy link

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 27.91 0 14.29 27.91
run.ts 27.91 0 14.29 27.91 14-64,69-77

@thesattiraju
Copy link
Contributor

@rgsubh any reason for holding off the merge?

@rgsubh rgsubh merged commit 24a3a12 into master Jul 1, 2020
@OliverMKing OliverMKing deleted the testcases branch February 2, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesattiraju thesattiraju thesattiraju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgsubh @thesattiraju