Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot/npm and yarn/actions/core 1.2.6 releases #9

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Dependabot/npm and yarn/actions/core 1.2.6 releases #9

merged 2 commits into from
Oct 29, 2020

Conversation

shigupt202
Copy link
Contributor

Updating actions core version in releases to 1.2.6

dependabot bot and others added 2 commits October 28, 2020 09:41
@shigupt202 shigupt202 linked an issue Oct 28, 2020 that may be closed by this pull request
use new add-path method #8
Closed
thesattiraju
thesattiraju approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@thesattiraju thesattiraju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This seems to be missing the add-path conversion, if that's already handled, ignore my comment.

@shigupt202
Copy link
Contributor Author

add-path is supposed to be converted to addPath, but we are already using addPath in this action.

@shigupt202 shigupt202 merged commit a625ca2 into releases/v1 Oct 29, 2020
@shigupt202 shigupt202 deleted the dependabot/npm_and_yarn/actions/core-1.2.6-releases branch October 29, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesattiraju thesattiraju thesattiraju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use new add-path method
2 participants
@shigupt202 @thesattiraju