incomplete bgp route map for RM_SET_SRC/RM_SET_SRC6 #3765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Azure/sonic-buildimage
Fix merging error in last commit
Modify test sample_output file
Merge branch 'master' into loopback, remove blank line
|
Build triggered for merge commit. |
|
retest vs please |
1 similar comment
|
retest vs please |
lguohan
reviewed
Nov 20, 2019
| ip address {{ lo_ipv4_addrs[0] }} | ||
| {% endif %} | ||
| {% if lo_ipv6_addrs|length > 0 %} | ||
| ipv6 address {{ lo_ipv6_addrs[0] | ip }}/{{ lo_ipv6_addrs[0] | prefixlen }} |
There was a problem hiding this comment.
this does not subscript the config db lo address change.
There was a problem hiding this comment.
Yes, so does all configs in templates, there are several commands referenced the lo address. To follow changes, a lot of work to do. I think it is a new requirement.
|
retest vs please |
|
hi Tyler, can you please separate the minigraph changes to another PR as we would need that to unblock |
|
obsoleted by 057ced0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the issue #3735
- How I did it
- How to verify it
test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)