[config] supplement loopback interface in mimigraph #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will prevent many of other templates working because templates exptects to see LOOPBACK interface as a list, not a dictionary. |
Hi Pavel, this was a generic change for all types of interfaces and handled already for Loopback - an you check this - https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-config-engine/sonic-cfggen#L100 ? |
|
retest vs please |
pavel-shirshov
dismissed
their stale review
Dismiss after conversation with Prince
prsunny
approved these changes
Nov 22, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Separate the minigraph changes from PR #3765. That is:
fix the "Loopback0": {}, by modifying minigraph.py(Prince has made the fix in sonic-utilities for db migrate (sonic-net/sonic-utilities#734))
- How I did it
- How to verify it
test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)