Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #265

Merged
merged 33 commits into from
Feb 21, 2022
Merged

Refactor tests #265

merged 33 commits into from
Feb 21, 2022

Conversation

krowlandson
Copy link
Contributor

Overview/Summary

This PR includes updates to the test framework to provide improved coverage for Virtual WAN connectivity.

This PR fixes/adds/changes/removes

  1. Update test framework to multi-stage deployment
  2. Add VWAN testing

Breaking Changes

none

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@krowlandson krowlandson self-assigned this Jan 28, 2022
@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@krowlandson
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

@jtracey93 @matt-FFFFFF... any thoughts on this PR before I merge into the vwan branch? Next update on vwan will be Wiki docs updates, then I think we can raise the PR from vwan to main ready for release v1.2.0.

@krowlandson krowlandson added the enhancement New feature or request label Feb 7, 2022
@krowlandson

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@krowlandson

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@krowlandson

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson merged commit 8de9bc6 into Azure:vwan Feb 21, 2022
krowlandson pushed a commit that referenced this pull request Mar 9, 2022
* Add VWAN capabilities to upstream branch (#250)

* Initial MVP for virtual wan and hub resources
* Update resource dependencies
* Refactor to create dedicated resources for vwan
* Refactor to simplify for management resources
* Replace `try()` with `lookup()`
* Update custom settings for Virtual WAN
* Add DNS links for spokes connected to Virtual Hubs
* Add virtual hub connections

* Fix incorrect VPN gateway name (#251)

* Fix incorrect VPN gateway name

* Refactor test framework for VWAN additions (#265)

* Refactor test deployments

* Update minimum supported provider version

* Fix linting error

* Update root_name

* Update unit test pipeline

* Fix certificate path error

* Rename job display names

* Update e2e test pipeline

* Update location variable

* Remove unused TF_PLAN_OUT variable

* Update parallelism environment variable

* Update path for terraform destroy

* Increase job timeouts for e2e

* Update OPA value generator for pwsh

* Add `planned_values.json` for each test case

* Remove trailing whitespace

* Update OPA tests script for new framework

* Add OPA tasks to Unit Tests job

* Remove `.sh` script (to be unified with `.ps1` version)

* Refactor OPA installation scripts

* Update execution bit

* Update task names

* Add readme to test framework

* Add VWAN config to connectivity settings

* Remove unsupported tags object from config

* Update minimum supported version to fix #271

* Fix #271 error deleting firewall

* Updates to fix #272

* Fix formatting error on fix for #273

* Fix to prevent lock file versions error

* Update rego files to reflect changes for #272

* Updated for latest test framework plans

* Update conftest baseline

* Add opt-out for `terraform destroy`

* Update for remote backend configuration

* Update dependsOn for test jobs

* Update execution bit on script file

* Output variables to pipeline

* Update auth config for backend

* Update backend config for SPN auth

* Update comment

* Move random `root_id` generation to strategy job

* Add SPN credentials to backend configuration

* Do not try to overwrite readonly variable

* Rename function for linting error

* Remove `use_microsoft_graph` due to error

* Add `az logout` step

* Troubleshoot `terraform init` error

* Map dependent variables

* Add `az cli` login to init step

* Troubleshoot auth issue for `terraform init`

* Add `ARM_CLIENT_SECRET` to `terraform init` steps

* Add dependent variables to e2e test jobs

* Split e2e tests into multiple jobs

* Update condition in test loop

* Rename jobs

* Update timeout on clean-up

* Update condition format

* Update dependencies

* Update conditions

* Update conditions

* Update timeout and conditions for e2e tests

* Rename tasks

* Update logic for `terraform destroy`

* Update logic for `terraform destroy`

* Update condition

* Rename e2e clean-up job
@krowlandson krowlandson deleted the refactor-tests branch April 1, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants