Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code to meet tflint's requirements #189

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Refactor code to meet tflint's requirements #189

merged 3 commits into from
Nov 24, 2022

Conversation

lonegunmanb
Copy link
Member

Describe your changes

This pull request refactor the Terraform code, rename some resources' name to snake case and added the moved blocks to avoid any breaking changes.

Issue number

#186

Checklist before requesting a review

  • [*] The pr title can be used to describe what this pr did in CHANGELOG.md file
  • [*] I have executed pre-commit on my machine
  • [*] I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests November 15, 2022 09:12 Inactive
@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #183, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb lonegunmanb temporarily deployed to acctests November 15, 2022 13:56 Inactive
@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb lonegunmanb temporarily deployed to acctests November 22, 2022 09:29 Inactive
@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #195, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #196, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

Potential Breaking Changes in 658ee14:
[delete] "Variables.storage_os_disk_size_gb.Name" from 'storage_os_disk_size_gb' to ''

@lonegunmanb lonegunmanb temporarily deployed to acctests November 24, 2022 05:24 Inactive
jiaweitao001
jiaweitao001 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jiaweitao001 jiaweitao001 merged commit d0fdaf5 into Azure:master Nov 24, 2022
@lonegunmanb lonegunmanb deleted the e-186 branch November 24, 2022 06:22
@yatzek yatzek mentioned this pull request Nov 24, 2022
Closed
1 task
lonegunmanb added a commit to lonegunmanb/terraform-azurerm-compute that referenced this pull request Nov 25, 2022
@lonegunmanb
fix unused variable issue, add the missing argument back to fix the b…
aa0ad1c 
…ug introduced by Azure#189
@lonegunmanb lonegunmanb mentioned this pull request Nov 25, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001