Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed var.location default value from "" to null #214

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Changed var.location default value from "" to null #214

merged 2 commits into from
Dec 22, 2022

Conversation

juanjojulian
Copy link
Contributor

@juanjojulian juanjojulian commented Dec 14, 2022

Describe your changes

Changed var.location default value from "" to null otherwise the following code will never be executed

data "azurerm_resource_group" "vm" {
  count = var.location == null ? 1 : 0

  name = var.resource_group_name
}

locals {
  location = var.location == null ? data.azurerm_resource_group.vm[0].location : var.location
  ssh_keys = compact(concat([var.ssh_key], var.extra_ssh_keys))
}

Checklist before requesting a review

  • [x ] The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@juanjojulian juanjojulian temporarily deployed to acctests December 15, 2022 07:30 — with GitHub Actions Inactive
@lonegunmanb
Copy link
Member

Thanks @juanjojulian for opening this pr! That's definitely a bug.

Our CI pipeline was failed, so would you please help us by reading the document and run the pre-commit command on your machine? It would be nice if you can run pr-check too before you commit so we can focus on e2e test. Thanks for your contribution and understanding!

@juanjojulian
Copy link
Contributor Author

@juanjojulian please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree

@juanjojulian juanjojulian temporarily deployed to acctests December 22, 2022 02:11 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Potential Breaking Changes in b52cc16:
[update] "Variables.location.Default" from '""' to 'null'

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanjojulian , LGTM! 🚀

@lonegunmanb lonegunmanb merged commit e34628c into Azure:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants