Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally create an availability set #228

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Optionally create an availability set #228

merged 4 commits into from
Feb 6, 2023

Conversation

DatsloJRel
Copy link
Contributor

Describe your changes

Add variable to optionally create an availability set

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR @DatsloJRel ! Overall looks good. Just as few comments to address.

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DatsloJRel for the update, only one tiny description issue remains.

variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor Author

@DatsloJRel DatsloJRel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested change.

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DatsloJRel, LGTM! 🚀

@lonegunmanb lonegunmanb merged commit 99193ca into Azure:master Feb 6, 2023
@DatsloJRel DatsloJRel deleted the availability-set branch February 7, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants