This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat(private_endpoint.tf) allow custom location on private-endpoint #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zioproto could you take a look at this PR? |
|
Hello, it seems you did not run the https://github.com/Azure/terraform-azurerm-openai?tab=readme-ov-file#contributing |
|
Hi @zioproto |
|
@zioproto Do you know, when this feature be released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The default location for the private-endpoint is calculated from the resource-group of the VNET.
Since there could be another VNET in another region in the same resource-group, we need the ability to specify the location from the VNET or a custom location