Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcgc, bug fix on encode string #1350

Merged

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Aug 12, 2024

Problem on TCGC 0.45.1 here Azure/cadl-ranch#656 (comment)

link #1264
link #1179

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 12, 2024

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

Add @hasJsonConverter for csharp only to indicate if JSON converter is needed

@azure-tools/typespec-client-generator-core - fix ✏️

Bug fix for encode as string on ModelProperty.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@iscai-msft iscai-msft merged commit 84d89d8 into Azure:release/august-2024 Aug 13, 2024
22 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the tcgc_encode-bug-fix branch August 13, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants