Add .WithForceRefresh support for silent broker flows #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bgavrilMS,
gladjohn,
neha-bhargava,
pmaytak and
trwalke
iulico-1
commented
Dec 7, 2023
src/client/Microsoft.Identity.Client/Platforms/Features/RuntimeBroker/RuntimeBroker.cs
Show resolved
Hide resolved
rayluo
reviewed
Dec 7, 2023
src/client/Microsoft.Identity.Client/Platforms/Features/RuntimeBroker/RuntimeBroker.cs
Show resolved
Hide resolved
trwalke
reviewed
Dec 7, 2023
src/client/Microsoft.Identity.Client/Platforms/Features/RuntimeBroker/RuntimeBroker.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Dec 7, 2023
bgavrilMS
force-pushed
the
iulico/invalidate-cache-broker
branch
from
d410edf to
07f3b97
Compare
ForceRefresh + WAM test (#4459)
|
@pmaytak - as you are on-call, can you please review this? The HOW has been discussed internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4457
Changes proposed in this request
Currently Broker flows don't allow bypassing broker cache when option .WithForceRefresh(true) is set. This PR proposes to fix that.
Testing
No e2e test infra seem to exist for e2e WAM tests.
Manual validation was done. Test app has been updated to support this option.
Performance impact
There's possibility that using builder .WithForceRefresh(true) will result in 2 network calls if the cache is already expired.