Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new CIAM authority #626

Merged
merged 8 commits into from
Apr 16, 2023
Merged

Support new CIAM authority #626

merged 8 commits into from
Apr 16, 2023

Conversation

siddhijain
Copy link
Contributor

@siddhijain siddhijain commented Apr 10, 2023

This PR takes care of supporting a new authority type CIAM as per this Epic https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2473109

@siddhijain siddhijain changed the title Initial commit Support new CIAM authority Apr 11, 2023
@bgavrilMS bgavrilMS requested a review from trwalke April 12, 2023 14:50
@@ -62,11 +65,29 @@ public void acquireTokenClientCredentials_ClientAssertion() throws Exception {

@Test
public void acquireTokenClientCredentials_ClientSecret_Ciam() throws Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @trwalke for E2E test with client_credentials.

Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great E2E tests, I have 1 question about authority detection.

Copy link

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor comments. They are optional. Approving.

@siddhijain siddhijain merged commit a965fbb into dev Apr 16, 2023
@siddhijain siddhijain deleted the add-ciam-authority branch April 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants