-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new CIAM authority #626
Conversation
@@ -62,11 +65,29 @@ public void acquireTokenClientCredentials_ClientAssertion() throws Exception { | |||
|
|||
@Test | |||
public void acquireTokenClientCredentials_ClientSecret_Ciam() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @trwalke for E2E test with client_credentials.
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/Authority.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great E2E tests, I have 1 question about authority detection.
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/CIAMAuthority.java
Outdated
Show resolved
Hide resolved
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/PublicClientApplication.java
Outdated
Show resolved
Hide resolved
msal4j-sdk/src/integrationtest/java/com.microsoft.aad.msal4j/AcquireTokenInteractiveIT.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple minor comments. They are optional. Approving.
This PR takes care of supporting a new authority type CIAM as per this Epic https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2473109