Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting CryptoOps and NativeAuthError for internal use #5482

Merged
merged 11 commits into from
Jan 9, 2023
Merged

Exporting CryptoOps and NativeAuthError for internal use #5482

merged 11 commits into from
Jan 9, 2023

Conversation

lalimasharda
Copy link
Contributor

@lalimasharda lalimasharda commented Dec 13, 2022 •
edited
Loading

Exporting CryptoOps class in internals.ts

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Dec 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #5482 (6eefe24) into dev (67a1646) will increase coverage by 2.45%.
The diff coverage is 100.00%.

Flag Coverage Δ
msal-angular 96.50% <ø> (ø)
msal-browser 86.47% <100.00%> (+<0.01%) ⬆️
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react 94.68% <ø> (ø)
node-token-validation ?
Impacted Files Coverage Δ
lib/msal-browser/src/internals.ts 100.00% <100.00%> (ø)
...on/src/authority/CloudInstanceDiscoveryResponse.ts
.../node-token-validation/src/config/Configuration.ts
...al-common/src/cache/entities/RefreshTokenEntity.ts
lib/msal-node/src/cache/serializer/Deserializer.ts
lib/msal-common/src/network/ThrottlingUtils.ts
lib/msal-core/src/AuthResponse.ts
...b/msal-common/src/client/ClientCredentialClient.ts
lib/msal-common/src/authority/RegionDiscovery.ts
...node-extensions/src/persistence/FilePersistence.ts
... and 148 more

@tnorling
Copy link
Collaborator

Please also update PR title and description

@lalimasharda lalimasharda changed the title Lalimas/browsercachingupdates Exporting CryptoOps for internal use Dec 13, 2022
@lalimasharda lalimasharda reopened this Dec 29, 2022
@lalimasharda lalimasharda changed the title Exporting CryptoOps for internal use Exporting CryptoOps and NativeAuthError for internal use Jan 9, 2023
@lalimasharda lalimasharda merged commit 1c8f7d7 into dev Jan 9, 2023
@lalimasharda lalimasharda deleted the lalimas/browsercachingupdates branch January 9, 2023 22:42
@ghost
Copy link

ghost commented Jan 10, 2023

🎉@azure/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@tnorling tnorling tnorling approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lalimasharda @codecov-commenter @tnorling @hectormmg