Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing B2C implementation to verify policy format #114

Merged
merged 8 commits into from
Oct 25, 2019
Merged

Conversation

abhidnya13
Copy link
Contributor

  • Changing implementation to check for policy string format instead of b2clogin.com
  • This supports custom domains with validateAuthority = True and sovereign clouds

@abhidnya13 abhidnya13 changed the title Changing policy identification for custom domains Changing B2C implementation to verify policy format Oct 23, 2019
@abhidnya13 abhidnya13 requested a review from rayluo October 23, 2019 22:19
Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your effort! This PR looks very clean!

PS: I noticed that all conversation this PR happened off-line. So documenting some reasoning of our implementation for future auditing/reference.

  • tweak it so that we do not have to do the split(...) call twice.
  • Besides, the latest implementation would wrap the long line by using implicit line continuation
  • and skip an unnecessary ternary operator.

@abhidnya13 abhidnya13 merged commit d226142 into dev Oct 25, 2019
@rayluo rayluo deleted the b2c_changes branch October 25, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants