Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Error message for 'sub' mismatch is incorrect after redeeming 'code' #194

Closed
brentschmaltz opened this issue Sep 8, 2016 · 0 comments
Closed

Error message for 'sub' mismatch is incorrect after redeeming 'code' #194

brentschmaltz opened this issue Sep 8, 2016 · 0 comments
Assignees
@lovemaths
Labels
done P1
Milestone
3.0.6

Comments

@brentschmaltz
Copy link
Member

When the 'sub' doesn't match the error message reports the 'iss' claim is mismatched.

if (subFromPrevIdToken && subFromPrevIdToken !== jwtClaims.sub)
return self.fail('After redeeming the code, iss in id_token from authorize_endpoint does not match iss in id_token from token_endpoint');
@brentschmaltz brentschmaltz changed the title Error message is for 'sub' mismatch is incorrect after redeeming 'code' Error message for 'sub' mismatch is incorrect after redeeming 'code' Sep 8, 2016
@lovemaths lovemaths added this to the 3.0.0 milestone Sep 9, 2016
@lovemaths lovemaths self-assigned this Sep 9, 2016
@lovemaths lovemaths added the P1 label Sep 9, 2016
lovemaths added a commit that referenced this issue Sep 27, 2016
@lovemaths
Fix OIDC B2C problems and add some breaking changes
d60bdb6 
(1) Rewrote the metadata loading and the configuration code. Restructured OIDCStrategy.
(2) #188 B2C mocha tests (partially done, waiting for the AAD fix of missing nonce to add test for hybrid/code flow)
(3) #165 rename 'callbackURL' and 'returnURL' to 'redirectUrl'.
(4) #189 Extensibility to allow issuer validation when going against commend end point
(5) #194 error message for 'sub' mismatch is incorrect after redeeming 'code'
(6) #218 missing email claim for B2C
@lovemaths lovemaths mentioned this issue Sep 27, 2016
Merged
@polita polita added the done label Sep 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lovemaths lovemaths

Labels
done P1
Projects
None yet
Milestone
3.0.6
Development

No branches or pull requests
3 participants
@brentschmaltz @lovemaths @polita