Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Remove default query support for access_tokens in bearerstrategy #195

Closed
brentschmaltz opened this issue Sep 8, 2016 · 0 comments
Closed
Assignees
Milestone

Comments

@brentschmaltz
Copy link
Member

https://tools.ietf.org/html/rfc6750#section-5.3 calls out not to use query unless absolutely necessary. Query parameters are commonly logged and maintained in browser history.

@lovemaths lovemaths added this to the 3.0.0 milestone Sep 9, 2016
@lovemaths lovemaths self-assigned this Sep 9, 2016
@lovemaths lovemaths added the P1 label Sep 9, 2016
lovemaths added a commit that referenced this issue Oct 1, 2016
(2) on common endpoint, user can set validateIssuer true if they provide issuer
(3) breaking changes:
    1. add isB2C option for using B2C
	2. no longer support user provided certificate, we only allow the certificate created from AAD metadata
	3. removed tenantName option for B2C. Instead of using common endpoint then replacing the 'common' with tenantName, we now ask user to directly provide the identityMetadata with tenantName.
lovemaths added a commit that referenced this issue Oct 1, 2016
(1) Issue #195 disallow bearer token in query
(2) on common endpoint, user can set validateIssuer true if they provide issuer
(3) breaking changes:
    1. add isB2C option for using B2C
	2. no longer support user provided certificate, we only allow the certificate created from AAD metadata
	3. removed tenantName option for B2C. Instead of using common endpoint then replacing the 'common' with tenantName, we now ask user to directly provide the identityMetadata with tenantName.
@lovemaths lovemaths added the done label Oct 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants