map the create thread result (Azure#14178)

AzureSDKAutomation · Mar 8, 2021 · bbd9e2a · bbd9e2a
1 parent 3f1d0e7
commit bbd9e2a
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/sdk/communication/communication-chat/src/chatClient.ts b/sdk/communication/communication-chat/src/chatClient.ts
@@ -39,7 +39,11 @@ import {
   ListChatThreadsOptions,
   DeleteChatThreadOptions
 } from "./models/options";
-import { mapToChatThreadSdkModel, mapToChatParticipantRestModel } from "./models/mappers";
+import {
+  mapToChatThreadSdkModel,
+  mapToChatParticipantRestModel,
+  mapToCreateChatThreadResultSdkModel
+} from "./models/mappers";
 import {
   ChatThreadInfo,
   CreateChatThreadResult,
@@ -140,7 +144,7 @@ export class ChatClient {
         },
         operationOptionsToRequestOptionsBase(updatedOptions)
       );
-      return result;
+      return mapToCreateChatThreadResultSdkModel(result);
     } catch (e) {
       span.setStatus({
         code: CanonicalCode.UNKNOWN,

diff --git a/sdk/communication/communication-chat/src/models/mappers.ts b/sdk/communication/communication-chat/src/models/mappers.ts
@@ -13,7 +13,8 @@ import {
   ChatThread,
   ChatParticipant,
   ChatMessageReadReceipt,
-  ChatMessageContent
+  ChatMessageContent,
+  CreateChatThreadResult
 } from "./models";
 
 /**
@@ -126,6 +127,24 @@ export const mapToChatThreadSdkModel = (chatThread: RestModel.ChatThread): ChatT
   }
 };
 
+/**
+ * @internal
+ * Mapping chat thread REST model to chat thread SDK model
+ */
+export const mapToCreateChatThreadResultSdkModel = (
+  result: RestModel.CreateChatThreadResult
+): CreateChatThreadResult => {
+  const { chatThread, ...rest } = result;
+  if (chatThread)
+    return {
+      ...rest,
+      chatThread: mapToChatThreadSdkModel(chatThread)
+    };
+  else {
+    return { ...rest };
+  }
+};
+
 /**
  * @internal
  * Mapping read receipt REST model to read receipt SDK model

diff --git a/sdk/communication/communication-chat/test/chatClient.mocked.spec.ts b/sdk/communication/communication-chat/test/chatClient.mocked.spec.ts
@@ -50,6 +50,11 @@ describe("[Mocked] ChatClient", async () => {
     sinon.assert.calledOnce(spy);
     assert.isDefined(createThreadResult.chatThread);
     assert.equal(createThreadResult.chatThread?.id, mockThread.id);
+    assert.equal(createThreadResult.chatThread?.createdBy?.kind, "communicationUser");
+    assert.deepEqual(
+      (createThreadResult.chatThread?.createdBy as CommunicationUserIdentifier).communicationUserId,
+      mockCreateThreadResult.chatThread?.createdByCommunicationIdentifier.communicationUser?.id
+    );
 
     const request = spy.getCall(0).args[0];