fix: Upgrade base-image to node.js 22.x LTS (#124)

* fix: Upgrade base-image to node.js 22.x LTS * fix: Error message unit tests * fix: Update error message for tests * fix: Error message update * fix: Tests error message * fix: Changed node version and modified build-backend-docker-image.yaml * fix: build-core-docker-image * fix: build.yaml * fix: Added branch on build.yaml * fix: Revert build.yaml
B-S-F · Dec 18, 2024 · fa338fe · fa338fe
1 parent 683a331
commit fa338fe
Show file tree

Hide file tree

Showing 29 changed files with 31 additions and 31 deletions.
diff --git a/.github/workflows/build-backend.yml b/.github/workflows/build-backend.yml
@@ -23,7 +23,7 @@ jobs:
         if: steps.cache.outputs.cache-hit != 'true'
         uses: actions/setup-node@v4
         with:
-          node-version: 18.18.2
+          node-version: 22
           cache: "npm"
           cache-dependency-path: qg-api-service/package-lock.json
 

diff --git a/.github/workflows/build-typescript-apps.yml b/.github/workflows/build-typescript-apps.yml
@@ -23,7 +23,7 @@ jobs:
         if: steps.cache.outputs.cache-hit != 'true'
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 22
           check-latest: true
           cache: 'npm'
           cache-dependency-path: yaku-apps-typescript/package-lock.json

diff --git a/core-image/Dockerfile b/core-image/Dockerfile
@@ -13,7 +13,7 @@ LABEL maintainer="Neutrinos GROW/PAT"
 LABEL description="YAKU core docker image based on Ubuntu 22.04 image"
 
 ARG DEBIAN_FRONTEND=noninteractive
-ARG NODE_VERSION=18
+ARG NODE_VERSION=22
 ARG USERNAME="qguser"
 ARG USER_UID=1001
 ARG USER_GID=1000

diff --git a/qg-api-service/qg-api-service/Dockerfile b/qg-api-service/qg-api-service/Dockerfile
@@ -6,7 +6,7 @@
 # BUILD FOR LOCAL DEVELOPMENT
 ###################
 
-ARG BASE_IMAGE_NAME="node:18-alpine"
+ARG BASE_IMAGE_NAME="node:22-alpine"
 
 FROM ${BASE_IMAGE_NAME} As development
 
@@ -21,7 +21,7 @@ RUN npm install -ws --include-workspace-root
 # BUILD FOR PRODUCTION
 ###################
 
-ARG BASE_IMAGE_NAME="node:18-alpine"
+ARG BASE_IMAGE_NAME="node:22-alpine"
 
 FROM ${BASE_IMAGE_NAME}  As build
 
@@ -46,7 +46,7 @@ USER node
 # PRODUCTION
 ###################
 
-ARG BASE_IMAGE_NAME="node:18-alpine"
+ARG BASE_IMAGE_NAME="node:22-alpine"
 
 FROM ${BASE_IMAGE_NAME}  As production
 

diff --git a/qg-api-service/scale-run-test/tsup.config.ts b/qg-api-service/scale-run-test/tsup.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/qg-api-service/yaku-cli/src/handlers/environment.spec.ts b/qg-api-service/yaku-cli/src/handlers/environment.spec.ts
@@ -131,7 +131,7 @@ describe('loadEnvironments()', () => {
     // the error message must be specific to permissions
     expect(consoleErrorSpy).toHaveBeenCalledWith(
       chalk.red(
-        `Failed to parse '${testEnvFilePath}' as JSON: SyntaxError: Unexpected token ! in JSON at position 0`,
+        `Failed to parse '${testEnvFilePath}' as JSON: SyntaxError: Unexpected token '!', \"![]\" is not valid JSON`,
       ),
     )
     expect(existsSyncSpy).toHaveBeenCalledWith(testEnvFilePath)

diff --git a/qg-api-service/yaku-cli/src/handlers/login.spec.ts b/qg-api-service/yaku-cli/src/handlers/login.spec.ts
@@ -78,7 +78,7 @@ describe('login()', () => {
 
     expect(consoleErrorSpy).toHaveBeenCalledWith(
       chalk.red(
-        `Failed to parse '${testEnvHome}/.yakurc' as JSON: SyntaxError: Unexpected token ! in JSON at position 0`,
+        `Failed to parse '${testEnvHome}/.yakurc' as JSON: SyntaxError: Unexpected token '!', \"!\" is not valid JSON`,
       ),
     )
     expect(consoleErrorSpy).toHaveBeenCalledWith(chalk.red('process.exit: 1'))

diff --git a/qg-api-service/yaku-client-lib/tsup.config.ts b/qg-api-service/yaku-client-lib/tsup.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/ado-work-items-evaluator/tsup.config.ts b/yaku-apps-typescript/apps/ado-work-items-evaluator/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   splitting: false,
   sourcemap: true,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
 })
diff --git a/yaku-apps-typescript/apps/ado-work-items-fetcher/tsup.config.ts b/yaku-apps-typescript/apps/ado-work-items-fetcher/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   splitting: false,
   sourcemap: true,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
 })
diff --git a/yaku-apps-typescript/apps/defender-for-cloud/tsup.config.ts b/yaku-apps-typescript/apps/defender-for-cloud/tsup.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/git-fetcher/tsup.config.ts b/yaku-apps-typescript/apps/git-fetcher/tsup.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/html-finalizer/tsup.config.ts b/yaku-apps-typescript/apps/html-finalizer/tsup.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/jira-evaluator/tsup.config.ts b/yaku-apps-typescript/apps/jira-evaluator/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   splitting: false,
   sourcemap: true,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
 })
diff --git a/yaku-apps-typescript/apps/jira-fetcher/tsup.config.ts b/yaku-apps-typescript/apps/jira-fetcher/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   splitting: false,
   sourcemap: true,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
 })
diff --git a/yaku-apps-typescript/apps/jira-finalizer/tsup.config.ts b/yaku-apps-typescript/apps/jira-finalizer/tsup.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   entry: ['src/**/*.ts', 'lib/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/json-evaluator/tsup.config.ts b/yaku-apps-typescript/apps/json-evaluator/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/manual-answer-evaluator/tsup.config.ts b/yaku-apps-typescript/apps/manual-answer-evaluator/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/mend-fetcher/tsup.config.ts b/yaku-apps-typescript/apps/mend-fetcher/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/smb-fetcher/tsup.config.ts b/yaku-apps-typescript/apps/smb-fetcher/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/apps/sonarqube/test/unit/commands/fetch/project-status.spec.ts b/yaku-apps-typescript/apps/sonarqube/test/unit/commands/fetch/project-status.spec.ts
@@ -103,7 +103,7 @@ describe('getProjectStatus', async () => {
         undefined,
       ),
     ).rejects.toThrowError(
-      'Could not parse sonarqube response as JSON, Unexpected token s in JSON at position 0',
+      `Could not parse sonarqube response as JSON, Unexpected token 's', "some invalid json" is not valid JSON`,
     )
   })
 })

diff --git a/yaku-apps-typescript/apps/sonarqube/test/unit/fetch/project-status.spec.ts b/yaku-apps-typescript/apps/sonarqube/test/unit/fetch/project-status.spec.ts
@@ -103,7 +103,7 @@ describe('getProjectStatus', async () => {
         undefined,
       ),
     ).rejects.toThrowError(
-      'Could not parse sonarqube response as JSON, Unexpected token s in JSON at position 0',
+      `Could not parse sonarqube response as JSON, Unexpected token 's', "some invalid json" is not valid JSON`,
     )
   })
 })

diff --git a/yaku-apps-typescript/apps/sonarqube/tsup.config.ts b/yaku-apps-typescript/apps/sonarqube/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   splitting: false,
   sourcemap: true,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
 })
diff --git a/yaku-apps-typescript/packages/autopilot-utils/tsup.config.ts b/yaku-apps-typescript/packages/autopilot-utils/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/packages/issue-validators/tsup.config.ts b/yaku-apps-typescript/packages/issue-validators/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/packages/json-evaluator-lib/tests/read-json.spec.ts b/yaku-apps-typescript/packages/json-evaluator-lib/tests/read-json.spec.ts
@@ -42,7 +42,7 @@ describe('readJson', () => {
     vi.mocked(readFile).mockResolvedValueOnce('invalid json')
 
     await expect(readJson('./invalid.json')).rejects.toThrow(
-      'File ./invalid.json could not be parsed, failed with error: SyntaxError: Unexpected token i in JSON at position 0',
+      `File ./invalid.json could not be parsed, failed with error: SyntaxError: Unexpected token 'i', "invalid json" is not valid JSON`,
     )
   })
 

diff --git a/yaku-apps-typescript/packages/json-evaluator-lib/tsup.config.ts b/yaku-apps-typescript/packages/json-evaluator-lib/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/packages/log-utils/tsup.config.ts b/yaku-apps-typescript/packages/log-utils/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,

diff --git a/yaku-apps-typescript/packages/markdown-utils/tsup.config.ts b/yaku-apps-typescript/packages/markdown-utils/tsup.config.ts
@@ -9,7 +9,7 @@ export default defineConfig({
   entry: ['src/**/*.ts'],
   splitting: false,
   clean: true,
-  target: 'node18',
+  target: 'node22',
   format: ['esm'],
   bundle: false,
   sourcemap: true,