Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: biome errors #113

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: biome errors #113

merged 1 commit into from
Dec 12, 2024

Conversation

wulmer
Copy link
Contributor

@wulmer wulmer commented Dec 12, 2024

Fixes #110

@wulmer wulmer force-pushed the fix/110-biome-errors branch from b1dbdb3 to 5a5dd81 Compare December 12, 2024 12:27
@wulmer
Copy link
Contributor Author

wulmer commented Dec 12, 2024

Hi @fbufler , I have no clue what I had to do to fix the biome warning in yaku-ui/frog-vue/env.d.ts, but this seemed to work.

Could you please have a look at this type definition in https://github.com/B-S-F/yaku/pull/113/files#diff-215c577c2de4dea650dd81b205682aef68b4f85503a9ca5bd5e3decf7cae8c4aR10

@wulmer wulmer requested a review from fbufler December 12, 2024 12:29
@github-actions GitHub Actions
Copy link

Code Coverage Report

Project Statements Rate Branch Rate Indicator
packages/autopilot-utils 96.71% 90.08% 💚
dist/coverage/python 96.71% 90.08% 💚
apps/splunk-fetcher 92.51% 82.00% 💚
apps/sharepoint-fetcher 84.83% 76.62% 💚
apps/sharepoint-evaluator 94.09% 90.48% 💚
apps/sharepoint 84.06% 67.24% 💚
apps/security-scanner 0.00% 0.00% 💔
apps/pex-tool 93.07% 78.05% 💚
apps/pdf-signature-evaluator 67.48% 48.80% 💛
apps/papsr 98.28% 94.74% 💚
apps/filecheck 98.53% 96.30% 💚
apps/excel-tools 78.37% 62.89% 💛
apps/artifactory-fetcher 98.51% 92.86% 💚
Total 87.16% 75.59% 💚

fbufler
fbufler approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@fbufler fbufler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@wulmer wulmer merged commit 063a77b into main Dec 12, 2024
8 checks passed
@wulmer wulmer deleted the fix/110-biome-errors branch December 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbufler fbufler fbufler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix biome errors
2 participants
@wulmer @fbufler