Merge pull request #5 from B612-Asteroid-Institute/kk/orbit-fix

detect impacts wasn't working for orbits
B612-Asteroid-Institute · May 15, 2024 · 11deff0 · 11deff0
2 parents 1cea461 + 1e0d02a
commit 11deff0
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/adam_core/propagator/adam_assist.py b/src/adam_core/propagator/adam_assist.py
@@ -454,12 +454,19 @@ def _detect_impacts(
                 distances = normalized_distance[within_radius]
                 impacting_orbits = time_step_results.apply_mask(within_radius)
 
-                new_impacts = EarthImpacts.from_kwargs(
-                    orbit_id=impacting_orbits.orbit_id,
-                    distance=distances,
-                    coordinates=impacting_orbits.coordinates,
-                    variant_id=impacting_orbits.variant_id,
-                )
+                if isinstance(orbits, VariantOrbits):
+                    new_impacts = EarthImpacts.from_kwargs(
+                        orbit_id=impacting_orbits.orbit_id,
+                        distance=distances,
+                        coordinates=impacting_orbits.coordinates,
+                        variant_id=impacting_orbits.variant_id,
+                    )
+                elif isinstance(orbits, Orbits):
+                    new_impacts = EarthImpacts.from_kwargs(
+                        orbit_id=impacting_orbits.orbit_id,
+                        distance=distances,
+                        coordinates=impacting_orbits.coordinates,
+                    )
                 if earth_impacts is None:
                     earth_impacts = new_impacts
                 else: