Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

884 generalize spreadsheet #1102

Merged
merged 55 commits into from
Apr 18, 2024
Merged

Conversation

andersoncedu
Copy link
Contributor

@andersoncedu andersoncedu commented Nov 17, 2023

Issue: Testing functions from spreadsheet.py

Fix: created a new file in test folder called test_spreadsheet.py, and tested almost every single function in spreadsheet.py

Also created an initial UI using a sidebar button, "Create Spreadsheet", and route for that button, however, this was stated to be outside the scope of our issue so it was not completed, only moved to a new issue.

Test:

  1. source setup.sh
  2. git checkout 884-Generalize-Spreadsheet
  3. ./database/reset_database.sh test
  4. tests/monitor.sh
    all the tests should be passing.

fix #884

@solijonovam solijonovam marked this pull request as ready for review December 4, 2023 21:09
Copy link
Contributor

@AndersonStettner AndersonStettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian and I have some problems with the tests, talk to us when you come in so we can go over everything.

app/logic/spreadsheet.py Outdated Show resolved Hide resolved
app/logic/spreadsheet.py Outdated Show resolved Hide resolved
app/controllers/admin/stats.py Outdated Show resolved Hide resolved
app/static/js/spreadsheetMaker.js Outdated Show resolved Hide resolved
Copy link
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would just reevaluate the test cases in general to make sure you are testing all possible scenarios.

tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
@andersoncedu andersoncedu marked this pull request as draft January 23, 2024 20:00
bledsoef

This comment was marked as resolved.

@Karina-Agliullova
Copy link
Contributor

Consider this comment #1102 (comment)

Copy link
Contributor

@hoerstl hoerstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good! Just a bunch of unnecessary .executes() and some incorrect/misleading comments but good job. I would like to see some more testing on the test_totalVolunteerHours() but otherwise great work!

app/logic/spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
tests/code/test_spreadsheet.py Outdated Show resolved Hide resolved
Copy link
Contributor

@azabeli azabeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I would suggest adding some doc string for some of the function definitions.

Copy link
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through everything and it looks good. If you make this one change I will go ahead and approve it. Nice work!

tests/code/test_spreadsheet.py Show resolved Hide resolved
Copy link

View Code Coverage

Copy link
Contributor

@AndersonStettner AndersonStettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - Finn

@AndersonStettner AndersonStettner dismissed stale reviews from bledsoef and hoerstl April 18, 2024 17:03

Stale

@AndersonStettner AndersonStettner merged commit 5471de1 into development Apr 18, 2024
5 checks passed
@AndersonStettner AndersonStettner deleted the 884-Generalize-Spreadsheet branch April 18, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize Spreadsheet queries and write tests for them
9 participants