-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
884 generalize spreadsheet #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brian and I have some problems with the tests, talk to us when you come in so we can go over everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I would just reevaluate the test cases in general to make sure you are testing all possible scenarios.
…wareDevTeam/celts into 884-Generalize-Spreadsheet
Consider this comment #1102 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good! Just a bunch of unnecessary .executes()
and some incorrect/misleading comments but good job. I would like to see some more testing on the test_totalVolunteerHours() but otherwise great work!
…wareDevTeam/celts into 884-Generalize-Spreadsheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I would suggest adding some doc string for some of the function definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through everything and it looks good. If you make this one change I will go ahead and approve it. Nice work!
…the tests. Additionally addressed comments.
…wareDevTeam/celts into 884-Generalize-Spreadsheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! - Finn
Issue: Testing functions from
spreadsheet.py
Fix: created a new file in test folder called
test_spreadsheet.py
, and tested almost every single function inspreadsheet.py
Also created an initial UI using a sidebar button, "Create Spreadsheet", and route for that button, however, this was stated to be outside the scope of our issue so it was not completed, only moved to a new issue.
Test:
source setup.sh
git checkout 884-Generalize-Spreadsheet
./database/reset_database.sh test
tests/monitor.sh
all the tests should be passing.
fix #884