Request other community engagement #1103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahimbaref
reviewed
Dec 4, 2023
There was a problem hiding this comment.
- "Other Credit" could be made a bit more descriptive
- a user can input anything in the hours field, I think it should be limited to numbers (not letters)
- company/organization box seems a little out of place
- Not sure the difference between Activity vs Activity/Service, they are 2 different fields)
app/controllers/minor/routes.py
Outdated
| pass | ||
| user = User.get_by_id(username) | ||
| terms = selectSurroundingTerms(g.current_term) | ||
| # filepaths = handleFileSelection() |
|
It says page not found after submitting the form |
… use other experience for the future use
|
There might be a problem here. |
BrianRamsay
requested changes
Jan 16, 2024
| from app.models import * | ||
| from app.models.term import Term | ||
|
|
||
| class OtherExperience(baseModel): |
There was a problem hiding this comment.
Add 'CCE' to the name somewhere
| term = ForeignKeyField(Term) | ||
| hours = IntegerField() | ||
| weeks = IntegerField() | ||
| service = CharField() |
There was a problem hiding this comment.
'description' is probably a better name for this, and matches what you have in the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Create a basic form that a student will fill in to request an experience completed outside of the college. The page should include: the student's name, the name of the position they worked/volunteered for, the total hours they worked/volunteered, the total weeks they worked/volunteered, a description of the work, the term the experience is going to be credited in, and a place to upload a file from a supervisor that verifies the student did work/volunteer the amount they said. It should also have 3 statuses associated with an "Other" engagement.
Fix: We created and rendered the page with the name of the student and a form to fill in other information like the name of the position they worked/volunteered for, total hours they worked/volunteered, the total weeks they worked/volunteered, description of the work, and we also created a place to upload a file from a supervisor that verifies the student did work/volunteer the number of hours they mentioned.
Test: load the following route to see the page: /cceMinor/username/requestOtherCommunityEngagement
When you load the page, you will see the form on the page where you can fill in the relevant information about the request and other community engagement. and upload the doc file from your supervisor.
resolving issue #990