-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of UI for Imported Courses #1111
Creation of UI for Imported Courses #1111
Conversation
… Imported Courses. Started working on Search instructor functionality in imported Courses modal
… the view of name in the Service Learning Faculty table
… imported courses
…ible on the browser
…tSoftwareDevTeam/celts into CreateCourseParticipantUI_#1059
…or for Imported Courses inside Modal for Altering Courses. Working on fix for Instructor name instead of Username when autocomplete suggestion is clicked
…tSoftwareDevTeam/celts into CreateCourseParticipantUI_#1059
…ng on displaying course instructors inside the imported courses modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give it a pass for all functional uses but there is one pretty severe bug I found that you need to address. I also threw in a bunch of formatting suggestions (some renaming of variables and parameter kinds of things).
…es to be more consistent.
Lawrence mentioned that the new functions in serviceLearningCourses.py didn't have a test, so this will need to be added since it's a logic file. |
Viewing and Creating course proposals are both broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… available on the course proposals page and modify status message for imported courses
Description
We have added the functionality to submit course participants and import courses for the registrar but there is no way to access that information outside of the database.
Issue
Once a course is imported using a CSV type file from the registrar, there are minimal information about that course, as the file is expected to have only the Course Abbreviation, the Term, and the Students taking that course. In that case, a more thorough access such as editing, viewing and printing some information such as Course Name, Course Credit, and Course Instructors is needed.
Solution
Fixes Issue #1059
View and Print leads to the normal Course Proposal page and Printing Page, while triggering Edit opens a modal in which the user can edit the Name, the Credit, as well as the Instructors for that course. The Course Abbreviation field is disabled for unicity purposes.
Files Changed or Added
courseManagement.py
routes.py in admin
slcManagement.js
manageServiceLearningCourses.html
test_course_management.py
InstructorTable.js
((file added)Tests
source setup.sh
commanddatabase/reset_database.sh
test to reset the test dataparseUpload_ValidTest.xlsx
file fromcelts/tests/files
Remarks