Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engagement Event Tab #1407

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Engagement Event Tab #1407

merged 6 commits into from
Feb 13, 2025

Conversation

WackyWeaver
Copy link
Contributor

@WackyWeaver WackyWeaver commented Feb 7, 2025

Issue Description

Fixes #1373

  • The Events List tab is not showing all the categories we want for organizing our events.

Changes

  • Added new function, getEngagementEvents, to return the events under the Education and Engagement Tab

  • Added additional logic to return the count of Engagement events

  • Wrote tests for new logic

  • Old look:
    image

  • New look:
    image

Testing

  • Switch to the branch, reset database, run the test suite, and review the tests to ensure they check all possible cases.
  • Create events and ensure that they are organized under the correct tabs and return the correct count.
  • Profit.

@ojmakinde ojmakinde marked this pull request as ready for review February 13, 2025 20:50
@ojmakinde ojmakinde requested a review from bledsoef February 13, 2025 20:51
Copy link

View Code Coverage

Copy link
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bledsoef bledsoef merged commit ffd90d3 into development Feb 13, 2025
5 checks passed
@bledsoef bledsoef deleted the 1373-Event-Tabs branch February 13, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events List tabs
3 participants