-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added button for resubmitting forms to banner #427
base: development
Are you sure you want to change the base?
Changes from all commits
146b20d
64b3a14
4d930a7
032baac
fe77afe
e52d967
cb7c404
19b48b2
5468221
16ec9b8
22b38ba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,6 +145,26 @@ function finalApproval() { //this method changes the status of the lsf from pend | |
}); | ||
} | ||
|
||
function studentHistoryModalClose(){ | ||
modal.style.display = "none"; | ||
} | ||
|
||
function submitToBanner(formId) { | ||
$.ajax({ | ||
type: "POST", | ||
url: "/admin/addToBanner/" + formId, | ||
success: function(response) { | ||
if (response.success) { | ||
msgFlash("Form submitted to banner successfully ", "success"); | ||
studentHistoryModalClose(); | ||
} else { | ||
msgFlash("Form failed to submit to banner", "fail"); | ||
studentHistoryModalClose(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider leaving the modal open to accept changes when the ajax fails. when you close it when it fails, it requires the user to open the modal again. Since there are three different fail conditions, it might be useful to have a more descriptive fail reason for the user. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the modal is not closed after failure, the flash message saying that if failed to submit won't appear. |
||
} | ||
} | ||
}); | ||
} | ||
|
||
var laborDenialInfo = []; //this arrary is for insertDenial() and finalDenial() methods | ||
//This method calls AJAX from checkforms methods in the controller | ||
function insertDenial(val) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does conn stand for? could you rename it so that it correlates to the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conn stands for Bonner connection, it is used in another function, wanted to keep it consistent