move dataset objects outside of models #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69 except for the GCNNs.
Datasets are not stored within the model (although this doesn't make an impact on either the speed/memory consumption).
The major memory consuming task was Captum Integrated Gradients, which explodes memory consumption, because many models are generated in memory without batching. Now, we use data loaders and compute feature importance in batches, which caps maximum memory usage to close to the amount used during training.
GNNs' feature importance function still needs to be adapted to this.