Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Convert single-channel to multi-channel image" tool #120

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

kostrykin
Copy link
Member

…add some other minor updates for improved clarity.


FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

@@ -0,0 +1,61 @@
<tool id="repeat_channels" name="Convert single-channel to multi-channel image" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="22.05">
<description>with NumPy</description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is numpy interesting for the users.

Copy link
Member Author

@kostrykin kostrykin Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, this tool is a very thin wrapper around numpy.dstack, and, regarding what we agreed as a community, this seems to be an edge case:

If a Galaxy tool is a thin tool wrapper (e.g, part of a major tool suite), then the name of the wrapped tool (and only the name of the wrapped tool, subsequent to the term “with” as in “with Bioformats”) should be used as the description of the tool […] The tool description should be empty if a tool is either not part of a major tool suite, or the main functionality of the tool is implemented in the wrapper.

One could argue that NumPy is a tool suite… But I see your point. However, there already are a few other tools "with NumPy". I'd be open to treat libraries as an exception here, as they are rather libraries than tool suites, but then it should be removed from all tools all together.

@kostrykin kostrykin merged commit 60cf803 into BMCV:master Apr 25, 2024
12 checks passed
@kostrykin kostrykin deleted the update/dev branch April 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants