[windows] when running installer, search for DLLs in the system directory only since the installer itself doesn't rely on any custom DLLs. #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory only since the installer itself doesn't rely on any custom DLLs. This fixes #2482. Signed-off-by: Vitalii Koshura <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6029 +/- ##
============================================
+ Coverage 5.45% 11.95% +6.50%
- Complexity 0 1068 +1068
============================================
Files 175 280 +105
Lines 29081 36974 +7893
Branches 7165 8533 +1368
============================================
+ Hits 1585 4420 +2835
- Misses 27449 32154 +4705
- Partials 47 400 +353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2482.