Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented smart phone access branch #77

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

hearjest
Copy link

I implemented the smartphone access branch by using [type].tsx, which allows me to redirect the browser to, for example, "/smart-phone-access," where I can then grab "smart-phone-access" from router.query.
This eliminates the need for three different files for each branch.
I've also renamed the old communication/computer access branch files, but I won't delete them right away.

Please view the video for a demo:
https://drive.google.com/file/d/1s2U9rfnOQaCaIwuqUTUh0CvICSpkqroD/view?usp=sharing

@hearjest hearjest requested a review from mochiakku October 31, 2024 00:59
@hearjest hearjest requested a review from DarianC26 as a code owner October 31, 2024 00:59
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
se-bch-als-resource-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:05am
se-bch-als-resource-app-62lu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:05am
se-bch-als-resource-app-y3wu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:05am

Copy link

@mochiakku mochiakku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarianC26 DarianC26 merged commit 6efdcf8 into BU-Spark:dev Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants