Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apy modal | Fixed alignment issue for mobile #2347

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Apy modal | Fixed alignment issue for mobile #2347

merged 2 commits into from
Sep 8, 2022

Conversation

mranilrai
Copy link
Collaborator

@mranilrai mranilrai commented Sep 8, 2022 •
edited
Loading

Screenshot 2022-09-08 at 8 04 12 PM

Screenshot 2022-09-08 at 9 20 36 PM

Screenshot 2022-09-08 at 9 20 28 PM

@mranilrai mranilrai self-assigned this Sep 8, 2022
@mranilrai mranilrai requested a review from okjintao as a code owner September 8, 2022 14:45
@mranilrai mranilrai linked an issue Sep 8, 2022 that may be closed by this pull request
feat: APY Evolution - Update Vault APY modal #2329
Closed
@mranilrai mranilrai requested a review from mrbasado September 8, 2022 14:45
@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 51.88% 2203/4246
🟡 Branches 44.14% 810/1835
🟡 Functions 45.12% 546/1210
🟢 Lines 69.15% 15617/22585

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🔴 src/components-v2/VaultApyBreakdownItem/index.tsx 8.7% 0% 0% 10.66% (-12.62% 🔻)
🟢 src/mobx/stores/VaultStore.ts 52.63% 50.77% 45.31% 83.98%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from a6bbf62

@mrbasado mrbasado merged commit dfdab2f into development Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbasado mrbasado mrbasado approved these changes

@okjintao okjintao Awaiting requested review from okjintao

Assignees

@mranilrai mranilrai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: APY Evolution - Update Vault APY modal
2 participants
@mranilrai @mrbasado